lkml.org 
[lkml]   [2019]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] dt-bindings: reset: Add bindings for the Meson-AXG SoC Reset Controller
On Mon, 12 Nov 2018, Thomas Gleixner wrote:

Gentle ping.

> Yixun,
>
> On Fri, 10 Nov 2017, Yixun Lan wrote:
>
> > +/*
> > + *
> > + * Copyright (c) 2016 BayLibre, SAS.
> > + * Author: Neil Armstrong <narmstrong@baylibre.com>
> > + *
> > + * Copyright (c) 2017 Amlogic, inc.
> > + * Author: Yixun Lan <yixun.lan@amlogic.com>
> > + *
> > + * SPDX-License-Identifier: (GPL-2.0+ OR BSD)
>
> There are two things wrong:
>
> 1) The placement. See Documentation/process/license-rules.rst
>
> 2) BSD is not a valid license id. You really have to decide which BSD
> variant to use.
>
> Please get that fixed as especially #2 is broken. The goal of using SPDX is
> to provide reliable license information for compliance tools.

This still is broken:

# scripts/spdxcheck.py include/dt-bindings/
include/dt-bindings/reset/amlogic,meson-axg-reset.h: 9:41 Invalid License ID: BSD

Thanks,

tglx

\
 
 \ /
  Last update: 2019-01-16 11:15    [W:0.091 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site