[lkml]   [2019]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RESENDING PATCH] powerpc/wii: properly disable use of BATs when requested.
Hi again,

On Tue, Jan 15, 2019 at 04:43:20PM +0000, Christophe Leroy wrote:
> 'nobats' kernel parameter or some options like CONFIG_DEBUG_PAGEALLOC
> deny the use of BATS for mapping memory.
> This patch makes sure that the specific wii RAM mapping function
> takes it into account as well.
> Fixes: de32400dd26e ("wii: use both mem1 and mem2 as ram")
> Cc:
> Signed-off-by: Christophe Leroy <>
> ---
> /* MEM2 64MB@0x10000000 */
> delta = wii_hole_start + wii_hole_size;
> + if (__map_without_bats)
> + return delta;
> +

Nothing is visibly broken without this patch, even with
CONFIG_DEBUG_PAGEALLOC (tested on top of v5.0-rc2), but the patch still
looks correct.

I'd prefer the 'if' block to be before the whole delta/size calculation,
to make the code slightly more readable because the delta and size
calculations stay in one visual block. It doesn't need to happen after
delta is calculated.

Reviewed-by: Jonathan Neuschäfer <>

[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2019-01-17 02:06    [W:0.064 / U:22.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site