lkml.org 
[lkml]   [2019]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v1 01/10] cpufreq: Add thermal_cooling_device pointer to struct cpufreq_policy
Date
On Monday, January 14, 2019 5:34:53 PM CET Amit Kucheria wrote:
> Several cpufreq drivers register themselves as thermal cooling devices.
> Adding a pointer to struct cpufreq_policy removes the need for them to
> store this pointer in a private data structure.
>
> We can then auto-register the cpufreq driver as a thermal cooling device
> from cpufreq core code.
>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> include/linux/cpufreq.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> index c86d6d8bdfed..7d0cf54125fa 100644
> --- a/include/linux/cpufreq.h
> +++ b/include/linux/cpufreq.h
> @@ -95,6 +95,11 @@ struct cpufreq_policy {
> struct cpufreq_frequency_table *freq_table;
> enum cpufreq_table_sorting freq_table_sorted;
>
> +#ifdef CONFIG_CPU_THERMAL
> + /* Pointer to the cooling device if used for thermal mitigation */
> + struct thermal_cooling_device *cooldev;
> +#endif
> +

Why here and not at the end of the struct?

> struct list_head policy_list;
> struct kobject kobj;
> struct completion kobj_unregister;
>

Also, I would suggest combining this one with patch [02/10].

\
 
 \ /
  Last update: 2019-01-16 23:57    [W:0.196 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site