[lkml]   [2019]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/2] kbuild: remove top-level built-in.a
Hi Nicholas,

On Tue, Jan 15, 2019 at 5:07 PM Nicholas Piggin <> wrote:
> Masahiro Yamada's on January 14, 2019 1:27 pm:
> > The symbol table in the final archive is unneeded because it is passed
> > to the linker after the --whole-archive option. Every object file in
> > the archive is included in the link anyway.
> >
> > Pass thin archives from subdirectories directly to the linker, and
> > remove the final archiving step.
> This seems like a good improvement. As far as I remember, it was slower
> to do the final link without the index built. Maybe I was testing it
> in a revision before moving those files into --whole-archive? If there
> is no slowdown, then I have no objection.

Thanks for the review.

I measured the performance of scripts/ with 'perf stat'.
(20 times for each)

Before this patch:

Performance counter stats for 'make vmlinux' (20 runs):

5.266796537 seconds time elapsed
( +- 0.12% )

After this patch:

Performance counter stats for 'make vmlinux' (20 runs):

4.945576395 seconds time elapsed

So, the performance is slightly better.

Maybe, does omitting the 'ar' save some time?

Anyway, this commit is good.

Best Regards
Masahiro Yamada

 \ /
  Last update: 2019-01-15 10:02    [W:0.079 / U:4.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site