lkml.org 
[lkml]   [2019]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing: Replace kzalloc with kcalloc
On Mon, 14 Jan 2019 22:34:08 -0600
"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:

> Replace kzalloc() function with its 2-factor argument form, kcalloc().
>
> This patch replaces cases of:
>
> kzalloc(a * b, gfp)
>
> with:
> kcalloc(a * b, gfp)

I think you meant:

kcalloc(a, b, gfp)

-- Steve

>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> kernel/trace/trace_probe.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
> index 9962cb5da8ac..57f0cbaf9c58 100644
> --- a/kernel/trace/trace_probe.c
> +++ b/kernel/trace/trace_probe.c
> @@ -429,7 +429,7 @@ static int traceprobe_parse_probe_arg_body(char *arg, ssize_t *size,
> parg->count);
> }
>
> - code = tmp = kzalloc(sizeof(*code) * FETCH_INSN_MAX, GFP_KERNEL);
> + code = tmp = kcalloc(FETCH_INSN_MAX, sizeof(*code), GFP_KERNEL);
> if (!code)
> return -ENOMEM;
> code[FETCH_INSN_MAX - 1].op = FETCH_OP_END;
> @@ -501,7 +501,7 @@ static int traceprobe_parse_probe_arg_body(char *arg, ssize_t *size,
> code->op = FETCH_OP_END;
>
> /* Shrink down the code buffer */
> - parg->code = kzalloc(sizeof(*code) * (code - tmp + 1), GFP_KERNEL);
> + parg->code = kcalloc(code - tmp + 1, sizeof(*code), GFP_KERNEL);
> if (!parg->code)
> ret = -ENOMEM;
> else

\
 
 \ /
  Last update: 2019-01-15 22:13    [W:0.049 / U:2.744 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site