[lkml]   [2019]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH 0/3] Introduce support for WP GPIO in the core SDHCI

While doing the bring up of a Zynq 7000 platform where the WP signal
of a SD slot is connected to a regular GPIO rather than through the
SDHCI WP pin, I realized that the GPIO described by wp-gpios was
properly requested, but it was in fact not used at all.

Indeed, the SDHCI core implements sdhci_check_ro() by:

- Calling a controller-specific ->get_ro() callback if it exists. A
few controller-specific drivers implement this, but not
sdhci-of-arasan, which is used on Zynq 7000.

- Using the SDHCI_PRESENT_STATE register, which reports the state of
the SDHCI interface WP pin, and obvisouly not the state of a
separate WP GPIO.

This patch series therefore changes sdhci_check_ro() to behave like
sdhci_get_cd(): use a GPIO first if available, and if not, fallback to
using the SDHCI_PRESENT_STATE register. Indeed, if there's a wp-gpios
described in the DT, it quite certainly indicates that the SDHCI WP
signal is not used, and the WP GPIO should be used instead.

As part of this series, two SDHCI drivers are modified to no longer
implement their custom ->get_ro() hook, since the core SDHCI now does
the right thing with the WP GPIO.

Best regards,


Thomas Petazzoni (3):
mmc: sdhci: use WP GPIO in sdhci_check_ro()
mmc: sdhci-omap: drop ->get_ro() implementation
mmc: sdhci-tegra: drop ->get_ro() implementation

drivers/mmc/host/sdhci-omap.c | 1 -
drivers/mmc/host/sdhci-tegra.c | 9 ---------
drivers/mmc/host/sdhci.c | 9 ++++++---
3 files changed, 6 insertions(+), 13 deletions(-)


 \ /
  Last update: 2019-01-15 17:29    [W:0.110 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site