Messages in this thread |  | | Date | Tue, 15 Jan 2019 16:15:49 +0100 | From | Daniel Vetter <> | Subject | Re: [PATCH 1/2] staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS_SETPAR |
| |
On Tue, Jan 15, 2019 at 02:45:53PM +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 15, 2019 at 01:12:28PM +0100, Daniel Vetter wrote: > > On Tue, Jan 15, 2019 at 11:38:29AM +0100, Greg Kroah-Hartman wrote: > > > On Tue, Jan 15, 2019 at 11:27:54AM +0100, Daniel Vetter wrote: > > > > It's a debug hack flag useful to work around driver bugs. That's not a > > > > good idea for a new driver. Especially for a new drm driver. > > > > > > > > Aside: the fbdev support should probably be converted over to the new > > > > generic fbdev support. > > > > > > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > Cc: Hans de Goede <hdegoede@redhat.com> > > > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > > > > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > > > > Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com> > > > > --- > > > > drivers/staging/vboxvideo/vbox_fb.c | 5 ----- > > > > 1 file changed, 5 deletions(-) > > > > > > > > > > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > Since Hans wants to destage vboxvideo this cycle probably best I merge > > this through drm-misc? Just to make sure it's not lost. > > Feel free to do so!
Applied, thanks for your review.
I think 2/2 is directly staging material for you (somehow get_maintainers.pl didn't add you to the cc: list, not sure why ...). -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
|  |