lkml.org 
[lkml]   [2019]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 1/3] staging: greybus: gpio: switch GPIO portions to use GPIOLIB_IRQCHIP
On Tue, Jan 15, 2019 at 04:13:17PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Jan 14, 2019 at 08:26:16PM +0530, Nishad Kamdar wrote:
> > Convert the GPIO driver to use the GPIO irqchip library
> > GPIOLIB_IRQCHIP instead of reimplementing the same.
> >
> > Reviewed-by: Johan Hovold <johan@kernel.org>
> > Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
>
> Did you test build this patch?
>
> It fails horribly for me:
>
> drivers/staging/greybus/gpio.c: In function ‘gb_gpio_request_handler’:
> drivers/staging/greybus/gpio.c:389:34: error: ‘struct gpio_chip’ has no member named ‘irq’
> irq = irq_find_mapping(ggc->chip.irq.domain, event->which);
> ^
> CC [M] drivers/staging/rtl8712/usb_intf.o
> drivers/staging/greybus/gpio.c: In function ‘gb_gpio_probe’:
> drivers/staging/greybus/gpio.c:577:8: error: implicit declaration of function ‘gpiochip_irqchip_add’; did you mean ‘gpiochip_add’? [-Werror=implicit-function-declaration]
> ret = gpiochip_irqchip_add(gpio, irqc, 0, handle_level_irq,
> ^~~~~~~~~~~~~~~~~~~~
> gpiochip_add
>
>
> Please be more careful...

Hm, this seems to be a problem on my side. You selected the new config
symbol, but my quick build system didn't catch that and it didnt
regenerate the kernel configuration, which causes this problem.

So this is fine, sorry for the noise, my fault.

greg k-h

\
 
 \ /
  Last update: 2019-01-15 16:16    [W:0.032 / U:4.088 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site