[lkml]   [2019]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: Clang warning in drivers/gpu/drm/i915/i915_debugfs.c
On Tue, 08 Jan 2019, Nathan Chancellor <> wrote:
> Hi all,
> Commit e845f099f1c6 ("drm/i915/dsc: Add Per connector debugfs node for
> DSC support/enable") causes a Clang warning:
> drivers/gpu/drm/i915/i915_debugfs.c:4961:17: warning: address of array 'intel_dp->dsc_dpcd' will always evaluate to 'true' [-Wpointer-bool-conversion]
> if (intel_dp->dsc_dpcd)
> ~~ ~~~~~~~~~~^~~~~~~~
> 1 warning generated.
> Did you mean to dereference it or should that print statement just
> always show? I normally would send a patch myself but since I'm not
> familiar with this code, I'd rather not shoot in the dark :) especially
> since it's for a trivial logging statement.

Fixed by fed85691b408 ("drm/i915: Fix the static code analysis warning
in debugfs"), thanks for the report & review on that one.


Jani Nikula, Intel Open Source Graphics Center

 \ /
  Last update: 2019-01-15 11:52    [W:0.060 / U:0.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site