Messages in this thread Patch in this message |  | | From | Daniel Vetter <> | Subject | [PATCH 1/2] staging/vboxvideo: Don't set FBINFO_MISC_ALWAYS_SETPAR | Date | Tue, 15 Jan 2019 11:27:54 +0100 |
| |
It's a debug hack flag useful to work around driver bugs. That's not a good idea for a new driver. Especially for a new drm driver.
Aside: the fbdev support should probably be converted over to the new generic fbdev support.
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Hans de Goede <hdegoede@redhat.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com> --- drivers/staging/vboxvideo/vbox_fb.c | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/drivers/staging/vboxvideo/vbox_fb.c b/drivers/staging/vboxvideo/vbox_fb.c index 2181c36c19ab..1da4cb7647b8 100644 --- a/drivers/staging/vboxvideo/vbox_fb.c +++ b/drivers/staging/vboxvideo/vbox_fb.c @@ -91,11 +91,6 @@ int vboxfb_create(struct drm_fb_helper *helper, fb = &vbox->afb.base; helper->fb = fb; - /* - * The last flag forces a mode set on VT switches even if the kernel - * does not think it is needed. - */ - info->flags = FBINFO_MISC_ALWAYS_SETPAR; info->fbops = &vboxfb_ops; /* -- 2.20.1
|  |