[lkml]   [2019]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe:[PATCH] x86/mm/mem_encrypt_identity : fix error useage to sizeof
On Mon, 7 Jan 2019, wrote:

> >> Fix error usage to sizeof. It should not use sizeof to pointer.
> >
> >.... because?
> >
> >The commit message needs to explain what the potential issue could be
> >and why it doesn't matter in this case.
> I see the definition of pte_t may be more than sizeof(unsigned long).
> So I think sizeof(pte_t) is safer.

What exactly is the difference between:

pte_t *p;




and what is safer about the latter?

Answer: No difference and nothing is safer because it's exactly the same.

In general we use sizeof(*p) simply because when the data type of p changes
you don't have to update the code, it just works and stays correct.



 \ /
  Last update: 2019-01-15 11:14    [W:0.054 / U:11.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site