lkml.org 
[lkml]   [2019]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] tracing: annotate implicit fall through
On Mon, 14 Jan 2019 21:30:37 +0100
Mathieu Malaterre <malat@debian.org> wrote:

> There is a plan to build the kernel with -Wimplicit-fallthrough and
> this place in the code produced a warning (W=1).
>
> This commit remove the following warning:
>
> kernel/trace/trace_probe.c:302:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>
> Signed-off-by: Mathieu Malaterre <malat@debian.org>

I'm pulling this in, but I'm changing the subject. Even when doing
clean ups, don't use the exact same subject for multiple patches, it
gets confusing when looking for a specific change.

Also, Linus prefers that a subject header starts with a capital letter.

[PATCH 1/2] tracing: Annotate implicit fall through in parse_probe_arg()

-- Steve


> ---
> kernel/trace/trace_probe.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
> index 9962cb5da8ac..89da34b326e3 100644
> --- a/kernel/trace/trace_probe.c
> +++ b/kernel/trace/trace_probe.c
> @@ -300,6 +300,7 @@ parse_probe_arg(char *arg, const struct fetch_type *type,
>
> case '+': /* deref memory */
> arg++; /* Skip '+', because kstrtol() rejects it. */
> + /* fall through */
> case '-':
> tmp = strchr(arg, '(');
> if (!tmp)

\
 
 \ /
  Last update: 2019-01-14 22:34    [W:0.046 / U:5.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site