lkml.org 
[lkml]   [2019]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] sbitmap: Protect swap_lock from softirqs
On Tue, Jan 15, 2019 at 5:25 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> The swap_lock used by sbitmap has a chain with locks taken from
> softirq, but the swap_lock is not protected from being preempted by
> softirqs.
>
> A chain exists of:
>
> sbq->ws[i].wait -> dispatch_wait_lock -> swap_lock
>
> Where the sbq->ws[i].wait lock can be taken from softirq context, which
> means all locks below it in the chain must also be protected from
> softirqs.
>
> Cc: stable@vger.kernel.org

Ack and applied, except for the "stable" tag.

Both the original buggy code, and the incorrect "shut up lockdep" were
only merged after 4.20.

Linus

\
 
 \ /
  Last update: 2019-01-14 20:33    [W:0.033 / U:6.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site