lkml.org 
[lkml]   [2019]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom
    On Mon, Jan 14, 2019 at 10:41 AM Evan Green <evgreen@chromium.org> wrote:
    >
    > On Mon, Jan 14, 2019 at 9:08 AM Doug Anderson <dianders@chromium.org> wrote:
    > >
    > > Hi,
    > >
    > > On Fri, Jan 11, 2019 at 7:37 PM Martin K. Petersen
    > > <martin.petersen@oracle.com> wrote:
    > > >
    > > >
    > > > Evan,
    > > >
    > > > > CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that
    > > > > this was the only possible PHY driver Qualcomm's UFS controller
    > > > > would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp,
    > > > > and phy-qcom-ufs is unused.
    > > > >
    > > > > Remove the select, since for SDM845 it adds useless drivers to the
    > > > > build.
    > > >
    > > > Applied to 5.1/scsi-queue.
    > >
    > > Should this be accompanied by a change to arch/arm64/configs/defconfig
    > > that sets 'CONFIG_PHY_QCOM_UFS=m'? I don't personally have any
    > > non-SDM845 devices to test on, but I'm sorta assuming they will all
    > > break without the defconfig update?
    >
    > Right, thanks for pointing that out. I'll send out another patch to
    > tweak the defconfig.

    Sent out at:
    https://lore.kernel.org/lkml/20190114190112.167922-1-evgreen@chromium.org/T/#u

    \
     
     \ /
      Last update: 2019-01-14 20:13    [W:4.417 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site