[lkml]   [2019]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 1/2] pinctrl: sunxi: Fix and simplify pin bank regulator handling
On Sun, Jan 13, 2019 at 10:57 AM Chen-Yu Tsai <> wrote:

> The new per-pin-bank regulator handling code in the sunxi pinctrl driver
> has mismatched conditions for enabling and disabling the regulator: it
> is enabled each time a pin is requested, but only disabled when the
> pin-bank's reference count reaches zero.
> Since we are doing reference counting already, there's no need to enable
> the regulator each time a pin is requested. Instead we can just do it
> for the first requested pin of each pin-bank. Thus we can reverse the
> test and bail out early if it's not the first occurrence.
> Fixes: 9a2a566adb00 ("pinctrl: sunxi: Deal with per-bank regulators")
> Acked-by: Maxime Ripard <>
> Signed-off-by: Chen-Yu Tsai <>
> ---
> Changes since v1:
> - Moved before the other fix. Both fixes are needed, but having this
> one first made reworking the other one easier.

Patch applied for fixes.

Linus Walleij

 \ /
  Last update: 2019-01-14 16:12    [W:0.071 / U:1.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site