lkml.org 
[lkml]   [2019]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
Subjectnext/pending-fixes boot bisection: v5.0-rc1-535-g727b373740d1 on bcm2837-rpi-3-b-32
From
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
* This automated bisection report was sent to you on the basis *
* that you may be involved with the breaking commit it has *
* found. No manual investigation has been done to verify it, *
* and the root cause of the problem may be somewhere else. *
* Hope this helps! *
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *

next/pending-fixes boot bisection: v5.0-rc1-535-g727b373740d1 on bcm2837-rpi-3-b-32

Summary:
Start: 727b373740d1 Merge remote-tracking branch 'drm-misc-fixes/for-linux-next-fixes'
Details: https://kernelci.org/boot/id/5c3c42c459b5145f216edd41
Plain log: https://storage.kernelci.org//next/pending-fixes/v5.0-rc1-535-g727b373740d1/arm/bcm2835_defconfig/lab-baylibre/boot-bcm2837-rpi-3-b.txt
HTML log: https://storage.kernelci.org//next/pending-fixes/v5.0-rc1-535-g727b373740d1/arm/bcm2835_defconfig/lab-baylibre/boot-bcm2837-rpi-3-b.html
Result: 8780cf1142a5 ASoC: soc-core: defer card probe until all component is added to list

Checks:
revert: PASS
verify: PASS

Parameters:
Tree: next
URL: http://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
Branch: pending-fixes
Target: bcm2837-rpi-3-b-32
CPU arch: arm
Lab: lab-baylibre
Config: bcm2835_defconfig
Test suite: boot

Breaking commit found:

-------------------------------------------------------------------------------
commit 8780cf1142a59568a3aa77959cbd76b2edb6fd81
Author: Ajit Pandey <ajitp@codeaurora.org>
Date: Wed Jan 9 14:17:07 2019 +0530

ASoC: soc-core: defer card probe until all component is added to list

DAI component probe is not called if it is not present
in component list during sound card registration.
Check if component is available in component list for
platform and cpu dai before soundcard registration.

Signed-off-by: Ajit Pandey <ajitp@codeaurora.org>
Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 0462b3ec977a..eec92f17dd15 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1027,7 +1027,6 @@ static int snd_soc_init_platform(struct snd_soc_card *card,
struct snd_soc_dai_link *dai_link)
{
struct snd_soc_dai_link_component *platform = dai_link->platform;
-
/*
* FIXME
*
@@ -1129,6 +1128,14 @@ static int soc_init_dai_link(struct snd_soc_card *card,
link->name);
return -EINVAL;
}
+
+ /*
+ * Defer card registartion if platform dai component is not added to
+ * component list.
+ */
+ if (!soc_find_component(link->platform->of_node, link->platform->name))
+ return -EPROBE_DEFER;
+
/*
* CPU device may be specified by either name or OF node, but
* can be left unspecified, and will be matched based on DAI
@@ -1140,6 +1147,14 @@ static int soc_init_dai_link(struct snd_soc_card *card,
link->name);
return -EINVAL;
}
+
+ /*
+ * Defer card registartion if cpu dai component is not added to
+ * component list.
+ */
+ if (!soc_find_component(link->cpu_of_node, link->cpu_name))
+ return -EPROBE_DEFER;
+
/*
* At least one of CPU DAI name or CPU device name/node must be
* specified
-------------------------------------------------------------------------------

Git bisection log:

-------------------------------------------------------------------------------
git bisect start
# good: [6b529fb0a3eabf9c4cc3e94c11477250379ce6d8] Merge tag 'for-5.0-rc1-tag' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux
git bisect good 6b529fb0a3eabf9c4cc3e94c11477250379ce6d8
# bad: [727b373740d1d3c6d3273cfc6e81d5e9a229b12d] Merge remote-tracking branch 'drm-misc-fixes/for-linux-next-fixes'
git bisect bad 727b373740d1d3c6d3273cfc6e81d5e9a229b12d
# good: [34aea5d2c46b2581ddf0b78a6119f85c1b3a8d1d] Merge remote-tracking branch 'net/master'
git bisect good 34aea5d2c46b2581ddf0b78a6119f85c1b3a8d1d
# bad: [52bb35a9520ac1746fb34687c5582695813aa00a] Merge remote-tracking branch 'char-misc.current/char-misc-linus'
git bisect bad 52bb35a9520ac1746fb34687c5582695813aa00a
# bad: [4baf5101d553aae944fa7dc7bd13772eb559d78b] Merge remote-tracking branch 'sound-asoc-fixes/for-linus'
git bisect bad 4baf5101d553aae944fa7dc7bd13772eb559d78b
# good: [49ff71f99a8826eda5cee76b69f15600d1cbf4b2] Merge remote-tracking branch 'rdma-fixes/for-rc'
git bisect good 49ff71f99a8826eda5cee76b69f15600d1cbf4b2
# good: [678e2b44c8e3fec3afc7202f1996a4500a50be93] ALSA: compress: prevent potential divide by zero bugs
git bisect good 678e2b44c8e3fec3afc7202f1996a4500a50be93
# good: [667e9334fa64da2273e36ce131b05ac9e47c5769] ASoC: tlv320aic32x4: Kernel OOPS while entering DAPM standby mode
git bisect good 667e9334fa64da2273e36ce131b05ac9e47c5769
# bad: [239b8b34a856777e562373ae0de605536a7ccade] ASoC: Intel: Boards: move the codec PLL configuration to _init
git bisect bad 239b8b34a856777e562373ae0de605536a7ccade
# bad: [8780cf1142a59568a3aa77959cbd76b2edb6fd81] ASoC: soc-core: defer card probe until all component is added to list
git bisect bad 8780cf1142a59568a3aa77959cbd76b2edb6fd81
# good: [44fabd8cdaaa3acb80ad2bb3b5c61ae2136af661] ASoC: atom: fix a missing check of snd_pcm_lib_malloc_pages
git bisect good 44fabd8cdaaa3acb80ad2bb3b5c61ae2136af661
# first bad commit: [8780cf1142a59568a3aa77959cbd76b2edb6fd81] ASoC: soc-core: defer card probe until all component is added to list
-------------------------------------------------------------------------------
\
 
 \ /
  Last update: 2019-01-14 15:38    [W:0.038 / U:0.896 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site