lkml.org 
[lkml]   [2019]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[RFC PATCH 0/4] watchdog: hpwdt: Fix NMI-related behaviour when CONFIG_HPWDT_NMI_DECODING is enabled
Date
Hi,

I found out that hpwdt alters NMI behaviour unexpectedly if compiled
with enabled CONFIG_HPWDT_NMI_DECODING:

* System starts to panic on any NMI with misleading message.
* Watchdog provided by hpwdt is not working after such panic.

Here are the patches that should fix this.

This is an RFC patch series because I am not sure that patches are
correct. Questions:

* Are "mynmi" flags always set on all supported iLO versions when iLO
is the source of NMI?
* Is it safe to reset "mynmi" flags to zero if code decides to not panic?

Ivan Mironov (4):
watchdog: hpwdt: Don't disable watchdog on NMI
watchdog: hpwdt: Don't panic on foreign NMI
watchdog: hpwdt: Add more information into message
watchdog: hpwdt: Make panic behaviour configurable

drivers/watchdog/hpwdt.c | 45 ++++++++++++++++++++++------------------
1 file changed, 25 insertions(+), 20 deletions(-)

--
2.20.1

\
 
 \ /
  Last update: 2019-01-14 03:37    [W:0.069 / U:83.332 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site