lkml.org 
[lkml]   [2019]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] hwmon: (adt7462) Mark expected switch fall-throughs
On Thu, Jan 10, 2019 at 10:24:29AM -0600, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Applied to hwmon-next.

Thanks,
Guenter

> ---
> drivers/hwmon/adt7462.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/hwmon/adt7462.c b/drivers/hwmon/adt7462.c
> index b0211f731251..030f5d49c061 100644
> --- a/drivers/hwmon/adt7462.c
> +++ b/drivers/hwmon/adt7462.c
> @@ -448,6 +448,7 @@ static const char *voltage_label(struct adt7462_data *data, int which)
> case 3:
> return "+1.5V";
> }
> + /* fall through */
> case 2:
> if (!(data->pin_cfg[1] & ADT7462_PIN22_INPUT))
> return "+12V3";
> @@ -505,6 +506,7 @@ static const char *voltage_label(struct adt7462_data *data, int which)
> case 3:
> return "+1.5";
> }
> + /* fall through */
> case 11:
> if (data->pin_cfg[3] >> ADT7462_PIN28_SHIFT ==
> ADT7462_PIN28_VOLT &&
> @@ -542,6 +544,7 @@ static int voltage_multiplier(struct adt7462_data *data, int which)
> case 3:
> return 7800;
> }
> + /* fall through */
> case 2:
> if (!(data->pin_cfg[1] & ADT7462_PIN22_INPUT))
> return 62500;
> @@ -599,6 +602,7 @@ static int voltage_multiplier(struct adt7462_data *data, int which)
> case 3:
> return 7800;
> }
> + /* fall through */
> case 11:
> case 12:
> if (data->pin_cfg[3] >> ADT7462_PIN28_SHIFT ==

\
 
 \ /
  Last update: 2019-01-10 19:32    [W:0.058 / U:15.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site