lkml.org 
[lkml]   [2019]   [Jan]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] base: fix a missing check of clk_prepare
On Mon, Dec 31, 2018 at 6:25 PM Pavel Machek <pavel@ucw.cz> wrote:
>
> On Wed 2018-12-26 10:37:54, Rafael J. Wysocki wrote:
> > On Wed, Dec 26, 2018 at 3:47 AM Kangjie Lu <kjlu@umn.edu> wrote:
> > >
> > > clk_prepare() could fail, so let's check its status, and if it fails,
> > > issue an error message.
> > >
> > > Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> > > ---
> > > drivers/base/power/clock_ops.c | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c
> > > index 5a42ae4078c2..cb6144fb24e2 100644
> > > --- a/drivers/base/power/clock_ops.c
> > > +++ b/drivers/base/power/clock_ops.c
> > > @@ -65,7 +65,9 @@ static void pm_clk_acquire(struct device *dev, struct pm_clock_entry *ce)
> > > if (IS_ERR(ce->clk)) {
> > > ce->status = PCE_STATUS_ERROR;
> > > } else {
> > > - clk_prepare(ce->clk);
> > > + if (clk_prepare(ce->clk))
> > > + dev_err(dev, "clk_prepare failed.\n");
> >
> > I'm not sure that this is useful. The code continues regardless of
> > the error anyway and it should at least set ce->status to
> > PCE_STATUS_ERROR in the failing case.
>
> Maybe this is not complete fix, but dev_err() is preferable to silent
> failure.

Preferable to you I suppose?

\
 
 \ /
  Last update: 2019-01-01 21:14    [W:0.058 / U:0.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site