[lkml]   [2018]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v11 03/11] firmware: xilinx: Add zynqmp IOCTL API for device control
Hi Olof,

On Sat, Sep 8, 2018 at 6:18 PM, Olof Johansson <> wrote:
> Hi,
> On Fri, Aug 3, 2018 at 10:53 AM, Jolly Shah <> wrote:
>> From: Rajan Vaja <>
>> Add ZynqMP firmware IOCTL API to control and configure
>> devices like PLLs, SD, Gem, etc.
>> Signed-off-by: Rajan Vaja <>
>> Signed-off-by: Jolly Shah <>
> This patch worries me somewhat. It's a transparent pass-through ioctl
> driver. Is there a spec available for what the implemented IOCTLs are?
> Should some of them be proper drivers instead of an opaque
> pass-through like this? Could some of them have stability impact on
> the platform such that there are security concerns and the list of
> arguments should somehow be sanitized?

I tend to agree with this, good catch.

> What's the intended usecase anyway? Just a debug tool during
> development, or something that you expect heavy use of by some
> userspace middleware?

I suspect it is another attempt to make userspace clocks/plls work? Scary.


 \ /
  Last update: 2018-09-09 21:20    [W:0.080 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site