lkml.org 
[lkml]   [2018]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3 4/8] usb: dwc3: implement stream transfer timeout
Date

HI Thinh,

>> ---
>> drivers/usb/dwc3/core.h | 7 +++++++
>> drivers/usb/dwc3/gadget.c | 36 ++++++++++++++++++++++++++++++++++++
>> 2 files changed, 43 insertions(+)
>>
>> diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index
>> 5bfb625..0b255e97 100644
>> --- a/drivers/usb/dwc3/core.h
>> +++ b/drivers/usb/dwc3/core.h
>> @@ -633,6 +633,11 @@ struct dwc3_event_buffer {
>>
>> #define DWC3_TRB_NUM 256
>>
>> +/*
>> + * Timeout value in msecs used by stream_timeout_timer when streams
>> +are enabled */
>> +#define STREAM_TIMEOUT_MS 50
>> +
>> /**
>> * struct dwc3_ep - device side endpoint representation
>> * @endpoint: usb endpoint
>> @@ -656,6 +661,7 @@ struct dwc3_event_buffer {
>> * @name: a human readable name e.g. ep1out-bulk
>> * @direction: true for TX, false for RX
>> * @stream_capable: true when streams are enabled
>> + * @stream_timeout_timer: timer used to aviod deadlock when streams
>> + are used
>
>Change aviod -> avoid. Also, the timer is being used when there's a deadlock rather
>than to avoid it. You probably need to explain what deadlock it is if you mentioned it
>here, but I think it's ok to simply say timeout timer for streams (unless Felipe has any
>objection).

Thanks for correcting again , will fix it in the next version of patch,

Thanks,
Anurag Kumar Vulisha

\
 
 \ /
  Last update: 2018-09-08 05:49    [W:0.366 / U:3.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site