lkml.org 
[lkml]   [2018]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iio: remove unnecessary condition judgment in am2315_trigger_handler
On Sat, 8 Sep 2018 17:59:13 +0530
Himanshu Jha <himanshujha199640@gmail.com> wrote:

> On Sat, Sep 08, 2018 at 06:57:36PM +0800, zhong jiang wrote:
> > The iterator in for_each_set_bit is never null, therefore, remove
> > the redundant conditional judgment.
> >
> > Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> > ---
> > drivers/iio/humidity/am2315.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/humidity/am2315.c b/drivers/iio/humidity/am2315.c
> > index 7d8669d..dc12e37 100644
> > --- a/drivers/iio/humidity/am2315.c
> > +++ b/drivers/iio/humidity/am2315.c
> > @@ -176,8 +176,7 @@ static irqreturn_t am2315_trigger_handler(int irq, void *p)
> > i = 0;
> > for_each_set_bit(bit, indio_dev->active_scan_mask,
> > indio_dev->masklength) {
> > - data->buffer[i] = (bit ? sensor_data.temp_data :
> > - sensor_data.hum_data);
> > + data->buffer[i] = sensor_data.temp_data;
>
> No, this seems wrong!
>
> We have buffer support to either take both readings(temp & humid)
> simultaneously, or only single channel using specified scan mask.

Key think is that bit most definitely can be 0 if the 0th bit is set.
This isn't a null check at all.

I'm curious, was this a by inspection case or did some script throw
this one up?

Thanks,

Jonathan

>
> Patch title should be:
>
> "iio: humidity: am2315: .... .. "
>
>
> Thanks

\
 
 \ /
  Last update: 2018-09-08 16:18    [W:0.092 / U:1.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site