[lkml]   [2018]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH V2] perf tools: Fix maps__find_symbol_by_name()
On Fri, Sep 07, 2018 at 11:51:16AM +0300, Adrian Hunter wrote:
> Commit 1c5aae7710bb ("perf machine: Create maps for x86 PTI entry
> trampolines") revealed a problem with maps__find_symbol_by_name() that
> resulted in probes not being found e.g.
> $ sudo perf probe xsk_mmap
> xsk_mmap is out of .text, skip it.
> Probe point 'xsk_mmap' not found.
> Error: Failed to add events.
> maps__find_symbol_by_name() can optionally return the map of the found
> symbol. It can get the map wrong because, in fact, the symbol is found
> on the map's dso, not allowing for the possibility that the dso has more
> than one map. Fix by always checking the map contains the symbol.
> Reported-by: Björn Töpel <>
> Tested-by: Björn Töpel <>

Acked-by: Jiri Olsa <>


 \ /
  Last update: 2018-09-07 11:58    [W:0.085 / U:6.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site