[lkml]   [2018]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH AUTOSEL 4.18 023/131] media: usbtv: use irqsave() in USB's complete callback
On Mon, Sep 03, 2018 at 09:16:32AM +0200, Sebastian Andrzej Siewior wrote:
>On 2018-09-02 13:03:27 [+0000], Sasha Levin wrote:
>> From: Sebastian Andrzej Siewior <>
>> [ Upstream commit 320905baa1dbddd3991c287432176d536e1d5b79 ]
>> The USB completion callback does not disable interrupts while acquiring
>> the lock. We want to remove the local_irq_disable() invocation from
>> __usb_hcd_giveback_urb() and therefore it is required for the callback
>> handler to disable the interrupts while acquiring the lock.
>> The callback may be invoked either in IRQ or BH context depending on the
>> USB host controller.
>> Use the _irqsave() variant of the locking primitives.
>> Cc: Hans Verkuil <>
>> Signed-off-by: Sebastian Andrzej Siewior <>
>> Signed-off-by: Mauro Carvalho Chehab <>
>> Signed-off-by: Sasha Levin <>
>This change (among the others that do the same in different drivers)
>does not fix a bug; it is just needed for "other reasons". While this
>series uncovered a few bugs, this is not one of them.
>There is no need to backport this stable.

Out it goes, thanks!
 \ /
  Last update: 2018-09-07 02:23    [W:0.098 / U:0.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site