lkml.org 
[lkml]   [2018]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] s390 patches for the 4.19 merge window #2
On Tue, 4 Sep 2018 17:16:31 -0700
Kees Cook <keescook@chromium.org> wrote:

> On Fri, Aug 24, 2018 at 12:42 AM, Martin Schwidefsky
> <schwidefsky@de.ibm.com> wrote:
> > Harald Freudenberger (5):
> > s390/zcrypt: hex string mask improvements for apmask and aqmask.
>
> This (and an earlier 2017 commit) adds VLAs, which are being
> removed[1] from the kernel:
>
> drivers/s390/crypto/ap_bus.c:980:3: warning: ISO C90 forbids variable
> length array ‘clrm’ [-Wvla]
> drivers/s390/crypto/ap_bus.c:981:3: warning: ISO C90 forbids variable
> length array ‘setm’ [-Wvla]
> drivers/s390/crypto/ap_bus.c:995:3: warning: ISO C90 forbids variable
> length array ‘setm’ [-Wvla]
>
> static int process_mask_arg(const char *str,
> unsigned long *bitmap, int bits,
> struct mutex *lock)
> ...
> DECLARE_BITMAP(clrm, bits);
> DECLARE_BITMAP(setm, bits);
>
> Can someone please adjust this to make these fixed size again?

Oops, sorry about that. We will provide a solution for this.

--
blue skies,
Martin.

"Reality continues to ruin my life." - Calvin.

\
 
 \ /
  Last update: 2018-09-05 07:57    [W:0.423 / U:5.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site