lkml.org 
[lkml]   [2018]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 07/12] Compiler Attributes: remove unneeded sparse (__CHECKER__) tests
On Wed, Sep 05, 2018 at 08:20:39PM +0200, Luc Van Oostenryck wrote:
> On Mon, Sep 03, 2018 at 10:33:11PM +0200, Miguel Ojeda wrote:
> > Sparse knows about a few more attributes now, so we can remove
> > the __CHECKER__ conditions from them (which, in turn, allow us
> > to move some of them later on to compiler_attributes.h).
> >
> > * assume_aligned: since sparse's commit ffc860b ("sparse:
> > ignore __assume_aligned__ attribute"), included in 0.5.1
> >
> > * error: since sparse's commit 0a04210 ("sparse: Add 'error'
> > to ignored attributes"), included in 0.5.0
> >
> > * hotpatch: since sparse's commit 6043210 ("sparse/parse.c:
> > ignore hotpatch attribute"), included in 0.5.1
> >
> > * warning: since sparse's commit 977365d ("Avoid "attribute
> > 'warning': unknown attribute" warning"), included in 0.4.2
>
> Hi,
>
> I hadn't noticed in the previous version but I see now that hotpatch
> & assume_aligned is only available since sparse 0.5.1 which is only
> 13 months old. It would be great if everyone use a recent version
> but I fear that a lot of people still use something less recent.
> v0.5.0 should be OK, though, it's more than 5 years old.
>
> Sorry for not having noticed this earlier.

Unlike GCC, I don't think it's at all unreasonable to assume a
*relatively* recent version of Sparse.

(Once we start assuming a version with __has_attribute support, this
will get even easier to handle.)

\
 
 \ /
  Last update: 2018-09-05 21:31    [W:0.147 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site