lkml.org 
[lkml]   [2018]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] sysctl: kselftests: use kernel module instead of built-in
From
Date
On 09/04/2018 08:20 PM, Lei Yang wrote:
> It uses modprobe $TEST_DRIVER in sysctl.sh, so update
> config to use "m" instead
>
> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
> ---
> tools/testing/selftests/sysctl/config | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/sysctl/config b/tools/testing/selftests/sysctl/config
> index 6ca1480..fc263ef 100644
> --- a/tools/testing/selftests/sysctl/config
> +++ b/tools/testing/selftests/sysctl/config
> @@ -1 +1 @@
> -CONFIG_TEST_SYSCTL=y
> +CONFIG_TEST_SYSCTL=m
>

What happens if it is a built-in? Can you elaborate in the changelog

On that note we might have other cases that do modprobe in scripts and
run into the same issue you are trying to solve. :)

thanks,
-- Shuah

\
 
 \ /
  Last update: 2018-09-05 18:48    [W:0.042 / U:5.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site