lkml.org 
[lkml]   [2018]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] staging: rtl8188eu: remove empty if statement in rtw_led.c
From
Date
On 9/5/18 10:13 AM, Dan Carpenter wrote:
> On Tue, Sep 04, 2018 at 01:16:15PM +0200, Michael Straube wrote:
>>
>> case LED_CTL_SITE_SURVEY:
>> - if ((pmlmepriv->LinkDetectInfo.bBusyTraffic) && (check_fwstate(pmlmepriv, _FW_LINKED))) {
>> - ;
>> - } else if (!pLed->bLedScanBlinkInProgress) {
>> + if (!pLed->bLedScanBlinkInProgress) {
>
> I think you have introduced a bug...

Ah yes I see now, thanks.
Would it be ok to merge the conditions in a single if?

if ((!pmlmepriv->LinkDetectInfo.bBusyTraffic ||
!check_fwstate(pmlmepriv, _FW_LINKED)) &&
!pLed->bLedScanBlinkInProgress) {


regards,
Michael

\
 
 \ /
  Last update: 2018-09-05 13:45    [W:0.089 / U:1.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site