lkml.org 
[lkml]   [2018]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 2/2] phy: zynqmp: Add dt bindings for ZynqMP phy
Date
Hi Vivek,

>> +Phy provider node
>> +=================
>> +
>> +Required properties:
>> +- compatible : Can be "xlnx,zynqmp-psgtr-v1.1" or "xlnx,zynqmp-psgtr"
>> + "xlnx,zynqmp-psgtr-v1.1" has "xlnx,tx_termination_fix" removed
>This is not very clear. You can rather mention this statement for the property.
>e.g. In "xlnx,tx_termination_fix" you can write - this is not required for "xlnx,zynqmp-
>psgtr-v1.1.
>

Thanks for spending your time in reviewing this patch, will correct this in the
next series of patch.

>> +
>> +- reg : Address and length of register sets for each device in
>> + "reg-names"
>> +
>> +- reg-names : The names of the register addresses corresponding to the
>> +
>> +lane1:
>> +- #phy-cells : Should be 4
>> +
>> +lane2:
>> +- #phy-cells : Should be 4
>> +
>> +lane3:
>> +- #phy-cells : Should be 4
>> +
>> +Example:
>> + serdes: zynqmp_phy@fd400000 {
>
>phy is not just the serdes. Also s/zynqmp_phy/phy
>
>This could be:
>                     zynqmp_phy: phy@fd400000
>
Thanks for correcting, will fix this in next series of this patch

Best Regards,
Anurag Kumar Vulisha
\
 
 \ /
  Last update: 2018-09-05 11:33    [W:0.048 / U:2.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site