lkml.org 
[lkml]   [2018]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Input: wm97xx: only unregister wm97xx_driver if it has been registered
On Tue, Sep 04, 2018 at 07:35:05PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> In the case where IS_BUILTIN(CONFIG_AC97_BUS)) is not true, the
> wm97xx_driver driver is being unregistered even it has not been
> previously registered. Fix this by only unregistering it if
> IS_BUILTIN(CONFIG_AC97_BUS)) is true. This fixes the warning
> message:
>
> [ 834.111248] ------------[ cut here ]------------
> [ 834.111248] Unexpected driver unregister!
> [ 834.111319] WARNING: CPU: 2 PID: 11749 at drivers/base/driver.c:193 driver_unregister+0x3b/0x40
> [ 834.111319] Modules linked in: wm97xx_ts(-) ....
>
> ..and a stack trace.
>
> To easily reproduce this, load and unload the module on a system where
> the hardware is not supported.
>
> Fixes: ae9d1b5fbd7b ("Input: wm97xx: add new AC97 bus support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---

Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles

\
 
 \ /
  Last update: 2018-09-05 11:17    [W:0.053 / U:12.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site