lkml.org 
[lkml]   [2018]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 2/2] f2fs: fix memory leak of percpu counter in fill_super()
Date
In fill_super -> init_percpu_info, we should destroy percpu counter
in error path, otherwise memory allcoated for percpu counter will
leak.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
fs/f2fs/super.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 627b9a959714..cc4bd264111e 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -2668,8 +2668,12 @@ static int init_percpu_info(struct f2fs_sb_info *sbi)
if (err)
return err;

- return percpu_counter_init(&sbi->total_valid_inode_count, 0,
+ err = percpu_counter_init(&sbi->total_valid_inode_count, 0,
GFP_KERNEL);
+ if (err)
+ percpu_counter_destroy(&sbi->alloc_valid_block_count);
+
+ return err;
}

#ifdef CONFIG_BLK_DEV_ZONED
--
2.18.0.rc1
\
 
 \ /
  Last update: 2018-09-05 08:55    [W:0.029 / U:7.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site