lkml.org 
[lkml]   [2018]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 1/2]: perf util: map data buffer for preserving collected data
From
Date
Hi,

On 04.09.2018 20:34, Andi Kleen wrote:
>> .sample = process_sample_event,
>> @@ -1678,6 +1680,8 @@ static struct option __record_options[] = {
>> "signal"),
>> OPT_BOOLEAN(0, "dry-run", &dry_run,
>> "Parse options then exit"),
>> + OPT_INTEGER(0, "aio", &record.opts.nr_cblocks,
>> + "asynchronous trace write operations (min: 1, max: 32, default: 2)"),
>
> would need to be documented in the manpage. But I would rather make it an
> ~/.perfconfig option

Yep, make sense, it requires to be configurable w/o recompilation and
at the same time its meaning is not obvious to be on the command line for a user.

>
>
> -Andi
>

\
 
 \ /
  Last update: 2018-09-04 19:51    [W:0.033 / U:7.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site