Messages in this thread |  | | Date | Tue, 4 Sep 2018 18:03:10 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v5 07/16] x86/pci: add Hygon PCI vendor and northbridge support |
| |
On Tue, Sep 04, 2018 at 11:45:02PM +0800, Pu Wen wrote: > I add these definitions to indicate that there are Hygon PCI device IDs. > You are right, I can just use the AMD f17h ones here.
Right, if this is a small piece where they're all together in a single compilation unit - like in this case - I don't see an issue with using the AMD ones. Later, when you start splitting functionality, you can do proper defines.
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
|  |