lkml.org 
[lkml]   [2018]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v5 10/13] nvme-pci: Add support for P2P memory in requests


On 04/09/18 09:16 AM, Jason Gunthorpe wrote:
>> if (iod->nents) {
>> - dma_unmap_sg(dev->dev, iod->sg, iod->nents, dma_dir);
>> + /* P2PDMA requests do not need to be unmapped */
>> + if (!is_pci_p2pdma_page(sg_page(iod->sg)))
>> + dma_unmap_sg(dev->dev, iod->sg, iod->nents, dma_dir);
>
> This seems like a poor direction, if we add IOMMU hairpin support we
> will need unmapping.

It can always be added later. In any case, you'll have to convince
Christoph who requested the change; I'm not that invested in this decision.

Logan

\
 
 \ /
  Last update: 2018-09-04 17:48    [W:0.057 / U:2.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site