lkml.org 
[lkml]   [2018]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v5 07/16] x86/pci: add Hygon PCI vendor and northbridge support
Date
On 2018/9/4 22:52, Borislav Petkov wrote:
>> Add Hygon support in amd_postcore_init(), early_root_info_init().
>
> This whole commit message needs to not say *what* the patch does.

Will rework the whole commit messages.

>> +#define PCI_DEVICE_ID_HYGON_18H_ROOT 0x1450
>> +#define PCI_DEVICE_ID_HYGON_18H_DF_F3 0x1463
>> +#define PCI_DEVICE_ID_HYGON_18H_DF_F4 0x1464
>
> Why are you adding those if you can use the AMD f17h ones? They're
the same.

I add these definitions to indicate that there are Hygon PCI device IDs.
You are right, I can just use the AMD f17h ones here.

--
Regards,
Pu Wen

\
 
 \ /
  Last update: 2018-09-04 17:46    [W:0.055 / U:24.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site