[lkml]   [2018]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/6] staging: erofs: formatting fix to NULL comparison

On 2018/9/3 9:59, Chao Yu wrote:
> On 2018/8/31 17:41, Dan Carpenter wrote:
>> On Fri, Aug 31, 2018 at 11:29:03AM +0800, Chao Yu wrote:
>>> Hi Xiang,
>>> I'm not against this change which follows checkpatch's rule, since I think this
>>> can help to unify coding style in different modules of Linux. Maybe cleanup in
>>> other filesystem is needed as well.
>> That code is old, and those filesystems are not in staging so we're not
>> going to change them.
> Yup, anyway, it can be decided by their maintainer if they want the cleanup.
>> Let's just apply the patch and not spend any time thinking about it.
>> Part of the point of style guidelines is so that we don't have to
>> repeat all these discussions over and over...
>> Btw, I have a patch for reviewing these. I've attached
>> it. -r NULL. I've seen some people screw up the
>> conversion so having an automated review is nice.
> Cool, thanks very much for providing this tools, it actually can help to save
> some time during review. :)

I am traveling in Tibet. Sorry for the late response.

OK, that is fine. I will follow the new kernel coding style strictly
for the upcoming code.

Reviewed-by: Gao Xiang <>

Gao Xiang

>> regards,
>> dan carpenter

 \ /
  Last update: 2018-09-03 06:24    [W:0.053 / U:4.864 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site