lkml.org 
[lkml]   [2018]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/4] staging: comedi: Correct multiline dereference as per TODO
From
Date
On 03/09/18 15:47, Ian Abbott wrote:
> On 30/08/18 18:32, Ray Clinton wrote:
>> Using checkpatch.pl I was able to find a multiline dereference which goes
>> again the coding style for the kernel. I'm still working on my email
>> client so
>> the indentation looks bad here (in gmail) but the arguments for
>> comedi_check_trigger_arg_min should go just under the opening (
>
> The patch description should describe what the patch does, not how bad
> the indentation loos in your email client.

"loos" ==> "looks"

Also, you sent 4 patches with the same subject line (other than the
PATCH 1/4 part). They should be different. You can include the driver
name in the patch subject line to distinguish them, e.g.:

staging: comedi: dt3000: Correct multiline dereference

--
-=( Ian Abbott <abbotti@mev.co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268. Registered address: )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-

\
 
 \ /
  Last update: 2018-09-03 17:02    [W:0.603 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site