[lkml]   [2018]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[tip:x86/core] x86/kprobes: Stop calling fixup_exception() from kprobe_fault_handler()
Commit-ID:  e3e4d5019c2dd0f91600f6df377b215a73d506fe
Author: Jann Horn <>
AuthorDate: Tue, 28 Aug 2018 22:14:17 +0200
Committer: Thomas Gleixner <>
CommitDate: Mon, 3 Sep 2018 15:12:08 +0200

x86/kprobes: Stop calling fixup_exception() from kprobe_fault_handler()

This removes the call into exception fixup that was added in commit
c28f896634f2 ("[PATCH] kprobes: fix broken fault handling for x86_64").

On X86, kprobe_fault_handler() is called from two places:
do_general_protection() (for #GP) and kprobes_fault() (for #PF). In both
paths, the fixup_exception() call in the kprobe fault handler is redundant.

In case of #GP, fixup_exception() is called immediately before
kprobe_fault_handler() is invoked, so no need to try that again. This
assumes that the kprobe's fault handler isn't going to do something crazy
like changing RIP so that it suddenly points to an instruction that does
userspace access.

For #PF on a kernel address from kernel space, after the kprobe fault
handler has run, no_context() is invoked, which calls fixup_exception().

Signed-off-by: Jann Horn <>
Signed-off-by: Thomas Gleixner <>
Tested-by: Kees Cook <>
Acked-by: Masami Hiramatsu <>
Cc: Andy Lutomirski <>
Cc: "Naveen N. Rao" <>
Cc: Anil S Keshavamurthy <>
Cc: "David S. Miller" <>
Cc: Alexander Viro <>
Cc: Borislav Petkov <>

arch/x86/kernel/kprobes/core.c | 9 ---------
1 file changed, 9 deletions(-)

diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c
index 467ac22691b0..f72a47b602e2 100644
--- a/arch/x86/kernel/kprobes/core.c
+++ b/arch/x86/kernel/kprobes/core.c
@@ -1020,15 +1020,6 @@ int kprobe_fault_handler(struct pt_regs *regs, int trapnr)
if (cur->fault_handler && cur->fault_handler(cur, regs, trapnr))
return 1;
- /*
- * In case the user-specified fault handler returned
- * zero, try to fix up.
- */
- if (fixup_exception(regs, trapnr))
- return 1;
- /* fixup routine could not handle it. */

return 0;
 \ /
  Last update: 2018-09-03 15:18    [W:0.125 / U:4.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site