[lkml]   [2018]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/4] ASoC: tlv320aic31xx: Add overflow detection support
On Fri, Aug 31, 2018 at 01:24:32PM -0500, Andrew F. Davis wrote:
> Similar to short circuit detection, when the ADC/DAC is saturated and
> overflows poor audio quality can result and should be reported to the
> user. This device support Automatic Dynamic Range Compression (DRC)
> to reduce this but it is not enabled currently in this driver.

> + if (value & AIC31XX_DAC_OF_LEFT)
> + dev_err(dev, "Left-channel DAC overflow has occurred\n");
> + if (value & AIC31XX_DAC_OF_RIGHT)
> + dev_err(dev, "Right-channel DAC overflow has occurred\n");

So, this will sound terrible but I'm not sure that unconditionally
shouting in the logs is the right thing to do here - people do sometimes
put non-audio signals through sound cards (using them as generic DACs
and ADCs) and it seems like it could get very spammy. Perhaps a lower
level warning message, some counters or even some control that allows
the warnings to be masked.
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2018-09-03 15:05    [W:0.060 / U:54.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site