lkml.org 
[lkml]   [2018]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] fat: Relax checks for sector size and media type
Date
Pali Rohár <pali.rohar@gmail.com> writes:

> Windows fastfat.sys driver accepts also media types 0x00 and 0x01 and
> sector sizes 128 and 256 bytes. Linux mkfs.fat can format disk also to
> larger FAT sector sizes then 4096 bytes, therefore relax also upper limit
> restriction.

> - if (!is_power_of_2(bpb->fat_sector_size)
> - || (bpb->fat_sector_size < 512)
> - || (bpb->fat_sector_size > 4096)) {
> + if (!is_power_of_2(bpb->fat_sector_size)) {

Just relaxing validation doesn't work. The block layer doesn't support
smaller than 512, and lager than PAGE_SIZE. (And in specification, fat
doesn't support lager than 4096.)

> static inline int fat_valid_media(u8 media)
> {
> - return 0xf8 <= media || media == 0xf0;
> + return 0xf8 <= media || media == 0xf0 || media == 0x00 || media == 0x01;
> }
> #endif /* !_LINUX_MSDOS_FS_H */

This is ok though, this would be for ancient floppy media.

Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

\
 
 \ /
  Last update: 2018-09-03 09:18    [W:0.060 / U:2.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site