lkml.org 
[lkml]   [2018]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 5/5] x86/mm: add WARN_ON_ONCE() for wrong large page mapping
On Tue, 21 Aug 2018, Bin Yang wrote:
> @@ -625,6 +625,7 @@ try_preserve_large_page(pte_t *kpte, unsigned long address,
>
> psize = page_level_size(level);
> pmask = page_level_mask(level);
> + addr = address & pmask;
>
> /*
> * Calculate the number of pages, which fit into this large
> @@ -636,6 +637,12 @@ try_preserve_large_page(pte_t *kpte, unsigned long address,
> cpa->numpages = numpages;
>
> /*
> + * The old pgprot should not have any protection bit. Otherwise,
> + * the existing mapping is wrong already.
> + */
> + WARN_ON_ONCE(needs_static_protections(old_prot, addr, psize, old_pfn));

The check itself is fine, but it just emits a warning and goes on as if
nothing happened.

We really want to think about a proper way to fix that up without overhead
for the sane case.

Thanks,

tglx

\
 
 \ /
  Last update: 2018-09-04 00:28    [W:0.145 / U:8.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site