[lkml]   [2018]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 4/4] platform/x86: intel_telemetry: report debugfs failure
On Mon, Sep 3, 2018 at 9:05 PM Rajneesh Bhardwaj
<> wrote:
> On some Goldmont based systems such as ASRock J3455M the BIOS may not
> enable the IPC1 device that provides access to the PMC and PUNIT. In
> such scenarios, the ioss and pss resources from the platform device can


> not be obtained and result in a invalid telemetry_plt_config.

What is telemetry_plt_config?

> This is also applicable to the platforms where the BIOS supports IPC1
> device under debug configurations but IPC1 is disabled by user or the
> policy.
> This change allows user to know the reason for not seeing entries under
> /sys/kernel/debug/telemetry/* when there is no apparent failure at boot.
> Cc: Matt Turner <>
> Cc: Len Brown <>
> Cc: Souvik Kumar Chakravarty <>
> Cc: Kuppuswamy Sathyanarayanan <>

> Bugzilla:
There should be not a blank line.

> Acked-by: Matt Turner <>
> Signed-off-by: Rajneesh Bhardwaj <>

> +exit:
> + pr_debug(pr_fmt(DRIVER_NAME) " Failed\n");

Completely useless.

Device core does it in generic way.

With Best Regards,
Andy Shevchenko

 \ /
  Last update: 2018-09-26 15:57    [W:1.050 / U:10.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site