lkml.org 
[lkml]   [2018]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/5] dt-binding: rtci-pcf8523: add quartz_load property
On Wed, Sep 26, 2018 at 08:51:21PM +0200, Alexandre Belloni wrote:
> On 26/09/2018 10:47:08-0500, Rob Herring wrote:
> > > > +Optional property:
> > > > +- nxp,quartz_load_12.5pF: The capacitive load on the quartz is 12.5 pF,
> > > > + which differ from the default value of 7 pF
> > > > +
> > >
> > > The boolean properties usually don't work well for RTCs because people
> > > usually want to keep any previous configuration that may have been done
> > > at the factory or in the bootloader so I would use:
> > >
> > > nxp,quartz_load_fF and this would be either 7000 or 12500.
> >
> > Use '-' rather than '_'.
> >
> > There's already a defined unit suffix of '-picofarads'. If you need
> > '-femtofarads', then please add to property-units.txt. Though I'd prefer
> > not as wouldn't a value of 12 (or 13) be close enough for the needs
> > here?
> >
>
> For that particular RTC, yes but the isl1208 has 0.5pF steps and the
> x1205 has 0.25pf steps. I'd prefer having a single generic property for
> all the RTCs: quartz-load-femtofarads.

I will change to use this, and update property-units.txt too, when I get
back to the patch set in a week or so.

Sam

\
 
 \ /
  Last update: 2018-09-26 22:43    [W:0.078 / U:1.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site