lkml.org 
[lkml]   [2018]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] staging: dgnc: Fix Kconfig help header and text
From
Date
On 9/25/18 11:46 AM, Greg Kroah-Hartman wrote:
> On Tue, Sep 25, 2018 at 10:22:24AM -0600, sehro rautenkranz wrote:
>> Replace Kconfig help header and text to match other modules. Issue found
>> my checkpatch.
>>
>> Spacing adjusted to match Documentation/process/coding-style.rst. Issue
>> reported by rdunlap@infradead.org. (try 2)
>
> The "try 2" needs go to below the --- line.
>
> Also, you need to properly version your patches so that I have a clue
> as to which is the "latest" one.
>
>> Signed-off-by: sehro rautenkranz <sehro@sehro.org>
>
> You forgot Randy's Reported-by.
>
> Also, properly Capitalize your name.
>
> v3?

and the help text is still not indented correctly:
use one tab + 2 spaces for help text.

--
~Randy

\
 
 \ /
  Last update: 2018-09-25 21:50    [W:1.773 / U:0.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site