lkml.org 
[lkml]   [2018]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: mt7621-mmc: Remove do {} while (0) loop for single statement macro
On Tue, Sep 18, 2018 at 01:27:11PM +0200, Greg Kroah-Hartman wrote:
> On Sat, Sep 15, 2018 at 06:47:51PM +0530, Nishad Kamdar wrote:
> > This patch removes do {} while (0) loop for single statement macros.
> > Issue found by checkpatch.
> >
> > Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
> > ---
> > drivers/staging/mt7621-mmc/sd.c | 28 +++++++---------------------
> > 1 file changed, 7 insertions(+), 21 deletions(-)
> >
> > diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c
> > index 7474f9ed7b5b..ec12a3a5a926 100644
> > --- a/drivers/staging/mt7621-mmc/sd.c
> > +++ b/drivers/staging/mt7621-mmc/sd.c
> > @@ -104,14 +104,10 @@ static int cd_active_low = 1;
> > /* gate means clock power down */
> > static int g_clk_gate = 0;
> > #define msdc_gate_clock(id) \
> > - do { \
> > - g_clk_gate &= ~(1 << ((id) + PERI_MSDC0_PDN)); \
> > - } while (0)
> > + (g_clk_gate &= ~(1 << ((id) + PERI_MSDC0_PDN)))
>
> This should become an inline function, right?
>
>
> > /* not like power down register. 1 means clock on. */
> > #define msdc_ungate_clock(id) \
> > - do { \
> > - g_clk_gate |= 1 << ((id) + PERI_MSDC0_PDN); \
> > - } while (0)
> > + (g_clk_gate |= 1 << ((id) + PERI_MSDC0_PDN))
>
> Same here.
>
> >
> > // do we need sync object or not
> > void msdc_clk_status(int *status)
> > @@ -170,9 +166,7 @@ static void msdc_clr_fifo(struct msdc_host *host)
> > } while (0)
> >
> > #define msdc_irq_restore(val) \
> > - do { \
> > - sdr_set_bits(host->base + MSDC_INTEN, val); \
> > - } while (0)
> > + (sdr_set_bits(host->base + MSDC_INTEN, val))
>
> Just call the one function where this is used and delete this #define.
>
> Same type of changes for the rest of these as well.
>
> thanks,
>
> greg k-h

Ok. I'll do that.

Thanks for the review.

regards,
nishad

\
 
 \ /
  Last update: 2018-09-23 11:34    [W:0.058 / U:0.832 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site