lkml.org 
[lkml]   [2018]   [Sep]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v6 04/13] PCI/P2PDMA: Introduce configfs/sysfs enable attribute helpers


On 2018-09-21 10:18 a.m., Bjorn Helgaas wrote:
> It'd be sort of nice if the contents of the sysfs file were valid
> things you could put *back* into it. But it looks like the contents
> might be "none", which isn't valid for the store. And the contents
> are never "on" or "off".

In fact, "none" would be accepted by strtobool() as a false (seeing it
starts with 'n' and strtobool() only looks at the first character).
However, per the rest of your feedback I've changed show() to report
"0", "1" or pci_name() and dropped "auto". This matches what the other
strtobool configfs attributes are doing in NVMe target.

Logan

\
 
 \ /
  Last update: 2018-09-21 23:12    [W:0.098 / U:4.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site