lkml.org 
[lkml]   [2018]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH RFC 0/2] hwmon: Add RPi PoE HAT fan driver
From
Date
On 09/02/2018 04:20 AM, Stefan Wahren wrote:
> This series is an early stage of the hwmon driver for the fan on the
> Raspberry Pi Power over Ethernet HAT [1]. At the end this should use a
> Device Tree Overlay.
>
> Changes by Stefan based on [2]:
> - reformat the downstream patches for submission
> - drop reboot notification
> - fix remaining checkpatch issues
> - add COMPILE_TEST to Kconfig
>
> The driver is mostly copy & paste from pwm-fan, which isn't good. Personally
> i see two options:
>
> 1) integrate the driver function into the pwm-fan driver (new compatible)
> 2) implement the core function as a PWM driver and use the pwm-fan driver on top
>

I don't really see the point of thise driver. Why not implement either of those ?
2) sounds like a perfect fit to me.

Guenter

> [1] - https://www.raspberrypi.org/products/poe-hat/
> [2] - https://github.com/raspberrypi/linux/commit/0f937c8dc3201ebffa6c617c616fd7c65db65959
>
> Serge Schneider (2):
> dt-bindings: hwmon: Add RPi PoE HAT documentation
> hwmon: Add RPi PoE HAT fan driver
>
> .../devicetree/bindings/hwmon/rpi-poe-fan.txt | 55 +++
> Documentation/hwmon/rpi-poe-fan | 15 +
> drivers/hwmon/Kconfig | 11 +
> drivers/hwmon/Makefile | 1 +
> drivers/hwmon/rpi-poe-fan.c | 414 +++++++++++++++++++++
> include/soc/bcm2835/raspberrypi-firmware.h | 2 +
> 6 files changed, 498 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/rpi-poe-fan.txt
> create mode 100644 Documentation/hwmon/rpi-poe-fan
> create mode 100644 drivers/hwmon/rpi-poe-fan.c
>

\
 
 \ /
  Last update: 2018-09-02 16:24    [W:0.076 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site