lkml.org 
[lkml]   [2018]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 18/20] tpm: use u32 instead of int for pcr index
On Tue, Sep 18, 2018 at 12:34:57PM +0300, Tomas Winkler wrote:
> TPM pcr indices cannot be negative, also the tpm
> commands accept u32 number as a pcr index.
>
> 1. Adjust the API to use u32 instead of int in all pcr related
> functions.

NAK.

> 2. Rename tpm1_pcr_read_dev to tpm1_pcr_read() to match
> the counterpart tpm2_pcr_read()

I would accept this a separate commit (and it should be a separate).

> 3. Remove redundant constants in tpm1_pcr_extend() function.
>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>

/Jarkko

\
 
 \ /
  Last update: 2018-09-19 17:22    [W:0.189 / U:10.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site