lkml.org 
[lkml]   [2018]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 01/11] asm-generic/tlb: Provide a comment
On Wed, Sep 19, 2018 at 01:23:29PM +0100, Will Deacon wrote:

> > > > + * which (when !need_flush_all; fullmm will have start = end = ~0UL) provides
> > > > + * the range that needs to be flushed to cover the pages to be freed.
> > >
> > > I don't understand the mention of need_flush_all here -- I didn't think it
> > > was used by the core code at all.
> >
> > The core does indeed not use that flag; but if the architecture set
> > that, the range is still ignored.
> >
> > Can you suggest clearer wording?
>
> The range is only ignored if the default tlb_flush() implementation is used
> though, right? Since this text is about the fields that tlb_flush() can use,
> I think we can just delete the part in brackets.

Well, any architecture that actually uses need_flush_all will obviously
require a tlb_flush implementation that looks at it.

But OK, I'll remove the note.

\
 
 \ /
  Last update: 2018-09-19 15:13    [W:0.063 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site