lkml.org 
[lkml]   [2018]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3 3/3] ARM: dts: r9a06g032: Add pinctrl node
Date
Hi Geert,

On 19 September 2018 10:24 Geert Uytterhoeven wrote:
> On Wed, Sep 19, 2018 at 11:18 AM Phil Edworthy wrote:
> > On 19 September 2018 10:15 Simon Horman wrote:
> > > On Mon, Sep 17, 2018 at 05:36:09PM +0100, Phil Edworthy wrote:
> > > > This provides a pinctrl driver for the Renesas R9A06G032 SoC
> > > >
> > > > Based on a patch originally written by Michel Pollet at Renesas.
> > > >
> > > > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> > >
> > > Thanks Phil, I will defer this patch pending acceptance of the bindings.
> > > Please continue to repost this patch with updates to the bindings or
> > > otherwise ping me once they have been accepted.
> > Thanks, however I will send a new version of this patch to remove the
> > clock-names prop as it is not needed.
>
> I haven't reviewed the bindings patch yet, but it's a good idea to have
> clock-names, even for a single clock.
> It makes life easier if the same module is reused or enhanced in a later SoC,
> with more clock inputs.
Ok, I'll put it back :)

I should be able to get a new version out today so you may want to delay
your review until then.

Thanks
Phil
\
 
 \ /
  Last update: 2018-09-19 11:28    [W:0.061 / U:6.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site